Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding colors #242

Closed
codewithnick opened this issue Jul 14, 2023 · 4 comments
Closed

adding colors #242

codewithnick opened this issue Jul 14, 2023 · 4 comments

Comments

@codewithnick
Copy link
Contributor

Description

Could not find anything related to changing color to print in the terminal, especially for printing ascii letters,
if this feature is not available then it would be good to add it?

@sepandhaghighi
Copy link
Owner

@codewithnick Hi
Thanks for your comment 💯
Text coloring in the terminal is a bit hacky! Some interesting libraries like termcolor work on it. So it's not necessary for art to support it directly.

>>> from termcolor import colored, cprint
>>> from art import text2art
>>> cprint(text2art("test"), "red")

@sadrasabouri What do you think?

@sadrasabouri
Copy link
Collaborator

@codewithnick Hi Thanks for your comment 💯 Text coloring in the terminal is a bit hacky! Some interesting libraries like termcolor work on it. So it's not necessary for art to support it directly.

>>> from termcolor import colored, cprint
>>> from art import text2art
>>> cprint(text2art("test"), "red")

@sadrasabouri What do you think?

You're right. It's better for packages to be atomic. I prefer art sticks to its main goal.

@codewithnick
Copy link
Contributor Author

I want to make a contribution to this repository do you have any ideas. I thought this was missing so bought it up.

@sadrasabouri
Copy link
Collaborator

@codewithnick you can start working on this issue.
Before starting anything please read the contribution guidelines.

PS: For getting an about how you should solve that issue, you may need to take a look at this PR after skimming the source code one. Ask your probable question at the #241 issue tracker and we will respond ASAP.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants