From f61bb9670593806e69e8b270e327986c6ea3e4f8 Mon Sep 17 00:00:00 2001 From: volkanceylan Date: Wed, 5 Jun 2024 19:21:47 +0300 Subject: [PATCH] Fix upload editors not showing the errors returned from TemporaryUpload, and assuming upload successful even when it is not due to blacklist or some other validation error --- packages/corelib/src/ui/helpers/uploadhelper.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/corelib/src/ui/helpers/uploadhelper.ts b/packages/corelib/src/ui/helpers/uploadhelper.ts index bce63f24a3..0ef07bafba 100644 --- a/packages/corelib/src/ui/helpers/uploadhelper.ts +++ b/packages/corelib/src/ui/helpers/uploadhelper.ts @@ -36,7 +36,14 @@ export namespace UploadHelper { new Uploader({ batchSize: 1, - batchSuccess: data => options.fileDone?.(data.response ?? {}, data.batch?.filePaths?.[0], data), + batchSuccess: data => { + const response: UploadResponse = data.response ?? {}; + if (response?.Error) { + notifyError(response.Error.Message); + return; + } + options.fileDone?.(response, data.batch?.filePaths?.[0], data); + }, input: uploadInput.getNode() as HTMLInputElement, dropZone: options.zone, batchStart: () => {