GitHubStrategy example crashes app

[juhanakristian]

The GitHubStrategy example in docs crashes the application with error Error: Promise rejected with value when clicking login.

Seems like the fix is to return the value of authenticator.authenticate in app/routes/auth/github.tsx

export let action: ActionFunction = ({ request }) => {
  return authenticator.authenticate("github", request);
};

Also the loader in app/routes/auth/github/calllback.tsx needs to be changed to return the value of authenticator.authenticate

export let loader: LoaderFunction = ({ request }) => {
  return authenticator.authenticate("github", request, {
    successRedirect: "/dashboard",
    failureRedirect: "/#",
  });
};

Tested with Remix 0.20.1.

I'd be happy to create a PR for this!

[sergiodxa]

Ahh you need to either return the value or await it making the loader/action an async function, if you want to send a PR to fix it I can merge it, if not I will send a PR in a few minutes.