Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Import from @remix-run/node #150

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Import from @remix-run/node #150

merged 1 commit into from
Apr 6, 2022

Conversation

machour
Copy link
Contributor

@machour machour commented Mar 29, 2022

See comment here: remix-run/remix#2503 (comment)

MichaelDeBoey
MichaelDeBoey suggested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still possible to get these imports from remix package, but once the codemod is ready it will be recommended to update all imports, so good to already do it here. 👍

This means we'll need to have at least v1.3.3 as a dependency though, as createCookieSessionStorage wasn't exported from @remix-run/node before that.

@sergiodxa sergiodxa merged commit b90ad6d into sergiodxa:main Apr 6, 2022
@MichaelDeBoey
Copy link
Contributor

@sergiodxa as stated above, this would be a breaking change to not use remix package internally as this resuires updated peerDependencies

@sergiodxa
Copy link
Owner

@sergiodxa as stated above, this would be a breaking change to not use remix package internally as this resuires updated peerDependencies

This only change docs and a test file, or direct change anything of how Remix Auth works.

@machour machour deleted the fix/cookie-import branch April 7, 2022 06:41
@MichaelDeBoey
Copy link
Contributor

@sergiodxa Oh sorry, I didn't realize @machour updated his PR 🙈

@sergiodxa sergiodxa added the documentation Improvements or additions to documentation label May 11, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey requested changes

@sergiodxa sergiodxa sergiodxa approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@machour @MichaelDeBoey @sergiodxa