Skip to content

Add support for optional name input #11

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jonathanmv opened this issue Aug 28, 2019 · 9 comments
Closed

Add support for optional name input #11

jonathanmv opened this issue Aug 28, 2019 · 9 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jonathanmv
Copy link

The name property gets a random id while the description and other fields get the right value.

#serverless.yml
myFunction:
  component: "@serverless/aws-lambda"
  inputs:
    name: my-function
    description: Searches videos within a location
    ....

Is there a different way I should set the lambda function name?

@eahefnawy
Copy link
Member

Thanks @jonathanmv ... yeah we are now auto generating names and the readme is out of date in that regard. But we'd love to have optional name input.

@eahefnawy eahefnawy changed the title name property ignored Add support for optional name input Sep 4, 2019
@eahefnawy eahefnawy added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 4, 2019
@jhappoldt
Copy link

Hi @eahefnawy. It looks like PR #16 addresses this issue. Is this something you intend to merge?

@eahefnawy
Copy link
Member

@jhappoldt yep will test and review today.

@himanshupnt
Copy link

@eahefnawy did you have a chance to review #16
as @jhappoldt had asked, is it something that's intended to be merged or there is something else in the pipeline?

there is one more for IAM - serverless-components/aws-iam-role#4

@himanshupnt
Copy link

@jhappoldt @eahefnawy any update on this being merged? #16 seem to be good.

@rmclaughlin-nelnet
Copy link

I am also interested in #16 getting merged. Is there an update?

@Podders
Copy link

Podders commented Feb 19, 2020

@eahefnawy did you find any time to review/merge this one? would be an amazing addition!

@weiss19ja
Copy link

I am also interested in #16 to get merged. Are any updates/improvements planned?

@eahefnawy
Copy link
Member

We've released a completely new version of serverless components and updated the lambda component, which includes this change. Please check out the README for more info, as config has changed significantly:

https://github.com/serverless-components/aws-lambda/

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants