Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

serverless-offline exec is broken #154

Closed
jgilbert01 opened this issue Jul 14, 2017 · 3 comments · Fixed by #155
Closed

serverless-offline exec is broken #154

jgilbert01 opened this issue Jul 14, 2017 · 3 comments · Fixed by #155
Labels
Milestone

Comments

@jgilbert01
Copy link
Contributor

This is a Bug Report

Description

Serverless-offline has a nifty feature called scoped execution that can be used for automated integration testing.

This exec feature is currently not working with serverless-webpack because the tests get executed before webpack watch has a chance to compile the source.

Proposed Solution

The proposed solution is to execute compile after validate and before watch. This will force a compile when serverless-offline is started but before the tests are executed and still support watch for non automated scenarios that do not have the race condition.

Additional Data

  • Serverless-Webpack Version 2.0.0:
  • Webpack version 3.0.0:
  • Serverless Framework Version 1.17.0:
  • Serverless-Offline Version 3.15.0:
@jgilbert-hobsons
Copy link

thx for accepting this merge request. is there any plan to publish a new version to npm?

@HyperBrain
Copy link
Member

Most likely today ;-)

@jgilbert-hobsons
Copy link

Excellent!!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants