Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Implementation of sending in optional params is not clear #229

Closed
rupakg opened this issue Aug 5, 2017 · 0 comments
Closed

Implementation of sending in optional params is not clear #229

rupakg opened this issue Aug 5, 2017 · 0 comments

Comments

@rupakg
Copy link
Contributor

rupakg commented Aug 5, 2017

As you can see I am passing in junk values for awsAccessKeyID and awsSecretAccessKey. It is not clear if the intention for passing in these values is for overriding default values for testing with diff. creds or not. Because it seems that it is ignoring the values sent in.

curl -X POST http://localhost:8056/v1/functions \
  -d '{
	"functionId": "test", 
	"provider": {
		"type": "awslambda",
		"arn": "arn:aws:lambda:us-east-1:063733696545:function:user-service-prod-test", 
		"region": "us-east-1",
		"awsAccessKeyID": "junk",
		"awsSecretAccessKey": "junk"
	}
}'

# response
{
    "functionId": "test",
    "provider": {
        "type": "awslambda",
        "arn": "arn:aws:lambda:us-east-1:063733696545:function:user-service-prod-test",
        "region": "us-east-1",
        "awsAccessKeyID": "junk",
        "awsSecretAccessKey": "junk"
    }
}
@mthenw mthenw mentioned this issue Aug 16, 2017
1 task
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants