Upgrade to new maintance rules #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
medikoo
commented
Feb 26, 2020
•
medikoo
commented
- Fix CI to actually run tests
- Bring back Node.js v6 support (accidentally removed with v2.3.3)
- Rely on @serverless/eslint-config
- Enforce Prettier formatting
- Update style in all files to conform to newly introduced rules
- Enforce semantic commit messages
- Introduce semi-automated release process
- Update Travis CI with release automation
- Remove Node.js v4 from CI setup (it was not supported for very long time)
- Cleanup .gitignore
- Remove configuration files specific to developer environment
It was removed (withuot major version bump) with v2.3.3
pmuens
approved these changes
Feb 27, 2020
| "chalk": "^2.4.2", | ||
| "fs-extra": "^8.1.0", | ||
| "googleapis": "^41.0.1", | ||
| "googleapis": "^39.2.0", |
There was a problem hiding this comment.
Is this breaking since it's a downgrade?
There was a problem hiding this comment.
I don't think so. All tests pass.
Also upgrade from v32 to v41 was made without any extra changes to code: https://github.com/serverless/serverless-google-cloudfunctions/pull/176/files
And that was actually breaking (as it dropped Node.js v6 support, CI didn't pick that as its setup was broken - just lint was run, no tests).
So this is an attempt to bring back support for Node.js v6 in v2 scope, which we will drop with v3
There was a problem hiding this comment.
Makes sense. Thanks for the clarification 👍
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.