Skip to content

Support serviceAccountEmail and GS Variable #215

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 11, 2020
Merged

Support serviceAccountEmail and GS Variable #215

merged 3 commits into from
May 11, 2020

Conversation

luisgreen
Copy link
Contributor

What did you implement

Added support for Google Cloud Storage variable fetch and Service Account Email

How can we verify it

serverless.yaml

service: my-super-functions

provider:
  name: google
  stage: dev
  runtime: nodejs8
  region: us-central1
  project: my-super-project

plugins:
  - serverless-google-cloudfunctions

package:
  exclude:
    - node_modules/**
    - .gitignore
    - .git/**

functions:
  gcp-sites:
    #<FUNCTION DEFINITION GOES HERE>
    serviceAccountEmail: devops-functions@${self:provider.project}.iam.gserviceaccount.com
    environment:
      ALGO: ${gs:my-superbucket/myfileinbucket.txt}

Is this ready for review?: YES
Is it a breaking change?: NO

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @luisgreen

@medikoo medikoo merged commit 1164495 into serverless:master May 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants