Skip to content

Commit 2505fc3

Browse files
Merge pull request #284 from fjtirado/id_really_mandatory
Force id to be mandatory
2 parents 6d11cfb + 44d6996 commit 2505fc3

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

api/src/main/resources/schema/workflow.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@
161161
}
162162
},
163163
"required": [
164+
"id",
164165
"name",
165166
"version",
166167
"states"

validation/src/test/java/io/serverlessworkflow/validation/test/WorkflowValidationTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public void testIncompleteYamlWithSchemaValidation() {
5858
List<ValidationError> validationErrors =
5959
workflowValidator.setSource("---\n" + "key: abc\n").validate();
6060
Assertions.assertNotNull(validationErrors);
61-
Assertions.assertEquals(3, validationErrors.size());
61+
Assertions.assertEquals(4, validationErrors.size());
6262
}
6363

6464
@Test
@@ -119,11 +119,10 @@ public void testWorkflowMissingStatesIdAndKey() {
119119
+ "}")
120120
.validate();
121121
Assertions.assertNotNull(validationErrors);
122-
Assertions.assertEquals(2, validationErrors.size());
122+
Assertions.assertEquals(1, validationErrors.size());
123123

124124
Assertions.assertEquals(
125-
"Workflow id or key should not be empty", validationErrors.get(0).getMessage());
126-
Assertions.assertEquals("No states found", validationErrors.get(1).getMessage());
125+
"$.id: is missing but it is required", validationErrors.get(0).getMessage());
127126
}
128127

129128
@Test

0 commit comments

Comments
 (0)