From 0af752edac695c9a8cc301baa8e77d21a628de59 Mon Sep 17 00:00:00 2001 From: "vikas.peri" Date: Mon, 25 Nov 2024 10:30:46 +0800 Subject: [PATCH 1/5] suppress the typescript errors to warn --- .eslintrc.json | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.eslintrc.json b/.eslintrc.json index 8075685..d81c440 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -25,7 +25,12 @@ "files": ["*.ts", "*.tsx"], "extends": ["plugin:@nrwl/nx/typescript"], "rules": { - "@typescript-eslint/no-empty-function": "off" + "@typescript-eslint/no-empty-function": "off", + "@typescript-eslint/no-empty-interface": "warn", // To be remvoed after upgrading to aws-sdk v3 + "@typescript-eslint/ban-types": "warn", // To be remvoed after upgrading to ndode 18 + "no-irregular-whitespace": "warn", // To be remvoed after upgrading to ndode 18 + "@typescript-eslint/no-var-requires": "warn", // To be remvoed after upgrading to ndode 18 + "no-var": "warn" // To be remvoed after upgrading to ndode 18 } }, { From 401668abd92649e636d995d863a9d8b18643e2ba Mon Sep 17 00:00:00 2001 From: "vikas.peri" Date: Mon, 25 Nov 2024 10:34:44 +0800 Subject: [PATCH 2/5] typo --- .eslintrc.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index d81c440..d38e420 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -26,11 +26,11 @@ "extends": ["plugin:@nrwl/nx/typescript"], "rules": { "@typescript-eslint/no-empty-function": "off", - "@typescript-eslint/no-empty-interface": "warn", // To be remvoed after upgrading to aws-sdk v3 - "@typescript-eslint/ban-types": "warn", // To be remvoed after upgrading to ndode 18 - "no-irregular-whitespace": "warn", // To be remvoed after upgrading to ndode 18 - "@typescript-eslint/no-var-requires": "warn", // To be remvoed after upgrading to ndode 18 - "no-var": "warn" // To be remvoed after upgrading to ndode 18 + "@typescript-eslint/no-empty-interface": "warn", // To be removed after upgrading to aws-sdk v3 + "@typescript-eslint/ban-types": "warn", // To be removed after upgrading to ndode 18 + "no-irregular-whitespace": "warn", // To be removed after upgrading to ndode 18 + "@typescript-eslint/no-var-requires": "warn", // To be removed after upgrading to ndode 18 + "no-var": "warn" // To be removed after upgrading to ndode 18 } }, { From 90b0ee8e30cadbad725a9b778a7d44c71a24556a Mon Sep 17 00:00:00 2001 From: "vikas.peri" Date: Mon, 25 Nov 2024 10:35:08 +0800 Subject: [PATCH 3/5] typo --- .eslintrc.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index d38e420..21bcb66 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -27,10 +27,10 @@ "rules": { "@typescript-eslint/no-empty-function": "off", "@typescript-eslint/no-empty-interface": "warn", // To be removed after upgrading to aws-sdk v3 - "@typescript-eslint/ban-types": "warn", // To be removed after upgrading to ndode 18 - "no-irregular-whitespace": "warn", // To be removed after upgrading to ndode 18 - "@typescript-eslint/no-var-requires": "warn", // To be removed after upgrading to ndode 18 - "no-var": "warn" // To be removed after upgrading to ndode 18 + "@typescript-eslint/ban-types": "warn", // To be removed after upgrading to node 18 + "no-irregular-whitespace": "warn", // To be removed after upgrading to node 18 + "@typescript-eslint/no-var-requires": "warn", // To be removed after upgrading to node 18 + "no-var": "warn" // To be removed after upgrading to node 18 } }, { From fa6836c638c49d0ec1a19d9dfcb4c5ea3fe3c98d Mon Sep 17 00:00:00 2001 From: "vikas.peri" Date: Mon, 25 Nov 2024 10:40:09 +0800 Subject: [PATCH 4/5] Fix the branch on pr --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 0cce8cd..8314ba4 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -3,7 +3,7 @@ name: PR Workflow on: pull_request: branches: - - master + - main jobs: build: From 297f3ea0cd2f778b617daa846da32445c74063b7 Mon Sep 17 00:00:00 2001 From: "vikas.peri" Date: Mon, 25 Nov 2024 10:45:29 +0800 Subject: [PATCH 5/5] add namespace --- .eslintrc.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc.json b/.eslintrc.json index 21bcb66..e13cf0e 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -30,7 +30,8 @@ "@typescript-eslint/ban-types": "warn", // To be removed after upgrading to node 18 "no-irregular-whitespace": "warn", // To be removed after upgrading to node 18 "@typescript-eslint/no-var-requires": "warn", // To be removed after upgrading to node 18 - "no-var": "warn" // To be removed after upgrading to node 18 + "no-var": "warn", // To be removed after upgrading to node 18 + "@typescript-eslint/prefer-namespace-keyword": "warn" } }, {