Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improvement: Get rid of coffeescript dependency #3111

Closed
woidda opened this issue Feb 22, 2019 · 4 comments
Closed

Improvement: Get rid of coffeescript dependency #3111

woidda opened this issue Feb 22, 2019 · 4 comments
Labels

Comments

@woidda
Copy link

woidda commented Feb 22, 2019

Actually this is a pretty easy task. If I had more time to be able to do the intial setup -- checking out rep etc -- I would do this via a pull request.

CoffeeScript is kind of obsolete with modern versions of ES and TypeScript.

Hence, this just as a small improvement suggestion:

  • There are only a couple of CoffeeScript files in this repo
  • With decaffeinate these transfiles are translated to ES6 in seconds (it works pretty well -- I tried it with the files)
  • Then you can remove the coffee-rails dependency.

Thanks to anybody willing to do this. This makes a lot of projects using this gem leaner.

@mshibuya
Copy link
Member

mshibuya commented May 2, 2019

It would be fantastic, waiting for PR!

@RocKhalil
Copy link
Contributor

Will try to do it myself this week :-)

@mroderick
Copy link
Contributor

@mshibuya #3168 removes CoffeeScript from this project

@woidda woidda changed the title Improvement: Get rid of coffeescript depency Improvement: Get rid of coffeescript dependency Jul 12, 2019
@GMorisot
Copy link

To note... If you add CKeditor to Rails admin, the bit of code in the docs to make it work in nested forms depends on coffeescript.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants