Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support lotimer / hitimer on release regions #1264

Open
pgcrowe opened this issue May 6, 2024 · 0 comments
Open

Support lotimer / hitimer on release regions #1264

pgcrowe opened this issue May 6, 2024 · 0 comments
Assignees
Labels
improvement Improve on existing functionality

Comments

@pgcrowe
Copy link

pgcrowe commented May 6, 2024

I finally got around to testing functionality of the new lotimer / hitimer opcodes, on trigger=release regions. For context, read the discussion in #1237. While lotimer / hitimer works as predicted on trigger=attack regions, it does not function at all for trigger=release regions, resulting in both release samples sounding at the same time.

Below is some of the example code I used for testing:

<group>
lokey=60 hikey=72
ampeg_release=0.1
amp_veltrack=0

<region> // Sustain region
group=1
sample=samples/sustain.wav
trigger=attack
lokey=60
hikey=72
ampeg_release=0.1 // Release fade, overlaps with short and long release regions

<region> // Short release region
group=1
sample=samples/short_release.wav
trigger=release
lokey=60
hikey=72
lotimer=0
hitimer=0.499 // This release should trigger ONLY if the sustain region is held 0.499 seconds or less.
ampeg_attack=0.1 // Attack time for crossfading
ampeg_decay=0.3 // Gradual decay to smoothly transition out

<region> // Long release region
group=1
sample=samples/short_release.wav
trigger=release
lokey=60
hikey=72
lotimer=0.500 // This release should trigger ONLY if the sustain region is held 0.5 seconds or more.
ampeg_attack=0.1 // Attack time for crossfading
ampeg_decay=0.3 // Gradual decay to smoothly transition out

See #1237 for further context. @redtide said to reopen the issue if I had any issues. I did comment a request to reopen, but I don't have permissions to reopen the issue.

Thanks for looking into this!
Pat

@pgcrowe pgcrowe changed the title Support lotimer / hitimer on release regions Support lotimer / hitimer on release regions Jul 1, 2024
@paulfd paulfd self-assigned this Oct 25, 2024
@paulfd paulfd added the improvement Improve on existing functionality label Oct 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement Improve on existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants