Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clicks when no ampeg_release #392

Closed
kinwie opened this issue Aug 25, 2020 · 5 comments · Fixed by #437
Closed

Clicks when no ampeg_release #392

kinwie opened this issue Aug 25, 2020 · 5 comments · Fixed by #437
Labels
bug Something isn't working

Comments

@kinwie
Copy link

kinwie commented Aug 25, 2020

While testing some sfz v1 organ presets which has no ampeg setting at all, I encountered clicks sound.
This seems cause by sfizz initial ampeg_release value.
Adding ampeg_release=0.0001 solved the click noises.
This clicks sound doesn't appear in other players. So I suggest to add a very short value for initial ampeg-release

Simple example can prove this case :

<region>
sample=*sine

This will sound smoother in sforzando and DropZone

@alcomposer
Copy link
Collaborator

This is a good simple suggestion.

If a user wanted the clicks, then add ampeg_attack=0 etc.

@kinwie
Copy link
Author

kinwie commented Aug 27, 2020

@alcomposer Maybe you mean ampeg_release=0?

@paulfd paulfd added the bug Something isn't working label Sep 22, 2020
@paulfd
Copy link
Member

paulfd commented Sep 22, 2020

Do you have any idea of the value used e.g. by sforzando? 0.0001?

@paulfd paulfd added this to the 0.5.0 milestone Sep 22, 2020
@kinwie
Copy link
Author

kinwie commented Sep 23, 2020

Do you have any idea of the value used e.g. by sforzando? 0.0001?

I made a comparison of 4 with images below (in order: sfizz, DropZone, RGC, sforzando) and image cut at the note-off point :

  • With just <region> sample=sine60.wav
    Untitled

  • Adding <region> sample=sine60.wav ampeg_release=0.001 seems to match enough three of them :
    Untitled2

@paulfd
Copy link
Member

paulfd commented Sep 23, 2020

Thanks alot @kinwie :) I'll get to it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants