Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

README examples are missing further command calls #4

Open
mbbroberg opened this issue Mar 7, 2019 · 3 comments
Open

README examples are missing further command calls #4

mbbroberg opened this issue Mar 7, 2019 · 3 comments

Comments

@mbbroberg
Copy link

It took me a little while to realize that piping is happening outside of gif's parsing of the command and requires further calls to the application. For instance:

gif emoji boom | gif rain <(gif emoji boom) > test.gif

Produces the result I expected from gif emoji boom | rain <(boom) > test.gif. It would be helpful for users to have that explained on the README. I'm happy to open a PR that does so, but I wanted to confirm you're interested in some further documentation before I take the time to write it 😄.

How's that sound @sgreben? Either way, thanks for making such a fun utility!

@sgreben
Copy link
Owner

sgreben commented Mar 8, 2019

Awesome, thanks @mbbroberg - glad you're having fun with it!

With the captions I was trying to strike a balance between "example" and "general idea", but clearly an actual example would have been better than "pseudo-shell".

So yeah, I'd definitely be happy to merge your fixes!

@mbbroberg
Copy link
Author

Awesome. I got a little caught up at work but hoping to get one going in the coming week. Others are welcome to beat me to it of course 🤘

@bandicootdancing
Copy link

After attempting to use rain I finally have the basic example working from the earlier comment. I can't seem to do anything else with the rain command. How would I add emojis or other small images to a background gif?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants