Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add image in attributes #38

Open
3 tasks done
agencetwogether opened this issue Feb 11, 2025 · 3 comments · May be fixed by #39
Open
3 tasks done

Add image in attributes #38

agencetwogether opened this issue Feb 11, 2025 · 3 comments · May be fixed by #39

Comments

@agencetwogether
Copy link

agencetwogether commented Feb 11, 2025

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

Hello,

I discovered your integration and this is very cool.

I'd like to use this data source : https://xmltvfr.fr/xmltv.php (eg. https://xmltvfr.fr/xmltv/xmltv_tnt.xz).

In this XML, there is <icon src="**url**"/> attribute, and it will be nice in sensor attribute, this image can be defined.

Thank you

Describe the solution you'd like

..

Describe alternatives you've considered

..

Additional context

..

@shadow578
Copy link
Owner

hi, do you mean having the image url as text in the attributes of the channel sensor? or as a separate image entity for every channel?

@agencetwogether
Copy link
Author

Hi,

My first idea was an image for each programme key from data source. This image will be present in sensor attributes.

But like you mention, it will be nice also to have channel image also and like that, in a custom card we can show image channel, and program image .

@shadow578 shadow578 linked a pull request Feb 14, 2025 that will close this issue
@shadow578
Copy link
Owner

Hi @agencetwogether ,
i've started working on this idea in PR #39.

as a quick side note (since i couldn't find anything), do you happen to know of any custom integrations that also provide image entities? preferrably some that make extensive use of unit tests?
i'm not quite sure if the way i'm handling the image entities is correct, but i couldn't find anyone else doing this kind of stuff...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants