Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

descriptor header size limit in 'esds' box #536

Closed
Jason239 opened this issue Jan 2, 2019 · 2 comments
Closed

descriptor header size limit in 'esds' box #536

Jason239 opened this issue Jan 2, 2019 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Jason239
Copy link

Jason239 commented Jan 2, 2019

Hi.

I wonder why the maximum header size of the esds(in 'mp4a') box is 64.
It is defined as 'kMaxDecoderSpecificInfoSize' in es_descriptor.cc.

What is the purpose of this atom, and why is there a limit of 64?
One of my files has an error because this value is 80. Is there a problem with this file?

@kqyang
Copy link
Contributor

kqyang commented Jan 2, 2019

@Jason239 The limit of 64 is an arbitrary value to avoid supporting size >= 128, which we do not think it would happen.

We'll fix the issue. Do you have a sample file we can use to verify the fix?

@kqyang kqyang added type: bug Something isn't working correctly and removed needs triage labels Jan 2, 2019
@kqyang kqyang added this to the v2.4 milestone Jan 2, 2019
@Jason239
Copy link
Author

Jason239 commented Jan 3, 2019

@kqyang kqyang self-assigned this Jan 8, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 28, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Apr 28, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants