Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

opinionated structure changes, fix build process, fix test, use local project for tests, semantic versioning #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

benatouba
Copy link

Hi,
thanks for the module. I'm offering you some changes/updates. Feel free to pick whatever you like or block.

  • fix the build process
    • it did not throw an error before but neither did it install anything
  • change the project structure.
    • It now contains a folder with the project name inside, where the code is.
  • changed the tests to use/import local files.
    • I think this speeds up the iteration when fixing/writing tests (No need to install in between)
  • more elaborate pyproject.toml
    • It now sets clear style guides and some more stuff
  • Fix test
    • the test for solar radiation out-of-bounds seemed odd to me. I changed it. Please check if correct.

Again thank you and I hope you find my changes helpful.

Best regards

P.S.: Might have messed up your gitignore, but that was in a subfolder before anyways.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant