Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update to PHPUnit 11 #2015

Closed
acelaya opened this issue Feb 19, 2024 · 2 comments · Fixed by #2125
Closed

Update to PHPUnit 11 #2015

acelaya opened this issue Feb 19, 2024 · 2 comments · Fixed by #2125
Labels
tech debt
Milestone
4.1.1

Comments

@acelaya
Copy link
Member

acelaya commented Feb 19, 2024

No description provided.

@acelaya acelaya added this to the 4.0.0 milestone Feb 19, 2024
@acelaya acelaya added this to Shlink Feb 19, 2024
@acelaya acelaya moved this to Todo in Shlink Feb 19, 2024
@acelaya
Copy link
Member Author

acelaya commented Feb 22, 2024 •
edited
Loading

PHPUnit 11 requires nikic/php-parser 5, which is currently conflicting with brick/varexporter, which requires that same package in v4

brick/varexporter is a dependency of laminas/laminas-config-aggregator, so first a new release of brick/varexporter is needed, followed by a new release of laminas/laminas-config-aggregator, unless brick/varexporter adds support for nikic/php-parser 5 without bumping the major version number.

@acelaya acelaya added the blocked Issues with some external dependency preventing to work on them label Feb 22, 2024
@acelaya acelaya modified the milestones: 4.0.0, 4.1.0 Mar 3, 2024
@acelaya acelaya removed the status in Shlink Mar 3, 2024
@acelaya acelaya moved this to Todo in Shlink Mar 31, 2024
@acelaya acelaya removed this from the 4.1.0 milestone Apr 9, 2024
@acelaya acelaya removed this from Shlink Apr 9, 2024
@acelaya acelaya added this to Shlink Apr 9, 2024
@acelaya
Copy link
Member Author

acelaya commented May 12, 2024

  • brick/varexporter 5 has been released, adding support for nikic/php-parser 5
  • laminas/laminas-config-aggregator 1.15 has been released, adding support for brick/varexporter 5

Unblocking.

@acelaya acelaya removed the blocked Issues with some external dependency preventing to work on them label May 12, 2024
@acelaya acelaya moved this to In Progress in Shlink May 12, 2024
@acelaya acelaya added this to the 4.1.1 milestone May 12, 2024
@acelaya acelaya moved this from In Progress to In review in Shlink May 12, 2024
@acelaya acelaya mentioned this issue May 12, 2024
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink May 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
tech debt
Projects
Shlink
Archived in project
Milestone
4.1.1
Development

Successfully merging a pull request may close this issue.

Update to PHPUnit 11 acelaya-forks/shlink
1 participant
@acelaya