Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] useOrderDetails.paymentChangeable is always false #1435

Open
1 task done
fabianeichinger opened this issue Nov 7, 2024 · 0 comments
Open
1 task done

[BUG] useOrderDetails.paymentChangeable is always false #1435

fabianeichinger opened this issue Nov 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@fabianeichinger
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The computed paymentChangeable from useOrderDetails is always false, even if the method may be changed.

Expected Behavior

The value of paymentChangeable from useOrderDetails should be true if the payment method on the order can be changed.

Steps To Reproduce

const { loadOrderDetails, paymentChangeable } = useOrderDetails(
  props.orderId,
);
await loadOrderDetails();
paymentChangeable.value // => always false

Environment

No response

Anything else?

checkPromotion is not sent as part of the request body one the readOrder request. Pretty sure this is a regression caused by the following change, as checkPromotion is in mergedAssociations but not mergedAssociations.associations.
1954022#diff-1aae20791a13b17b807d9677e2a8ba59b0bb6d3aa8716bc0a80d5ed09af61d41L205-R218

@fabianeichinger fabianeichinger added the bug Something isn't working label Nov 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Developer Backlog
Development

No branches or pull requests

1 participant