Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

New horizontal rule regex breaks backwards compatibility (and GFM compliance) #317

Closed
tivie opened this issue Dec 20, 2016 · 4 comments
Closed

New horizontal rule regex breaks backwards compatibility (and GFM compliance) #317

tivie opened this issue Dec 20, 2016 · 4 comments
Assignees
@tivie
Milestone
Make showdown's G...

Comments

@tivie
Copy link
Member

tivie commented Dec 20, 2016

The new regex breaks backwards compatibility in the following cases:

  • ---: not parsed as horizontal rule
  • - - -: not parsed as horizontal rule
@tivie tivie self-assigned this Dec 20, 2016
@tivie tivie closed this as completed in 113f5f6 Dec 21, 2016
@schoettler
Copy link

schoettler commented Aug 23, 2018 •
edited
Loading

Still not parsed as horizontal rule (?) (from Markdown to HTML)

@tivie
Copy link
Member Author

tivie commented Aug 23, 2018

@schoettler It's working fine. Was fixed in 113f5f6

@schoettler
Copy link

Whoops, needs a line break, my apologies

--- *works

text --- *does not work

As per Markdown spec

@tivie
Copy link
Member Author

tivie commented Aug 27, 2018

no prob

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tivie tivie

Labels
None yet
Projects
None yet
Milestone
Make showdown's GFM mode pristine
Development

No branches or pull requests
2 participants
@tivie @schoettler