Fix ReactAsyncIterables issue when formatting values directly into undefined/nulls
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s having the format function's result ignored if it returns `undefined` or `null`
shtaif
pushed a commit
that referenced
this pull request
Jan 6, 2025
## [0.4.0](v0.3.0...v0.4.0) (2025-01-06) ### Features * add to package exports the `IterationResultSet` type returned from `useAsyncIterMulti` ([#33](#33)) ([b0c8899](b0c8899)) * implement the new `useAsyncIterMulti` hook ([#28](#28)) ([d813fa0](d813fa0)) ### Bug Fixes * `ReactAsyncIterable`s wrapping iters which yield non-nullable values are having the format function's result ignored if it returned `undefined` or `null` ([#32](#32)) ([828d872](828d872)) ### Documentation * various docs edits ([#31](#31)) ([3f08461](3f08461))
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
ReactAsyncIterableis wrapping an underlying async iterable that itself yields any non-nullable values, but using aformatFnthat formats directly intoundefinedornull- they'll be ignored and the underlying iterable's original yielding would actually be seen. TheformatFnin such WAS invoked, however the internal logic would ignore its result and continue with the unformatted original value instead in case this result wasundefinedornull.