Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No hover state on BaseButton when attr HREF or TO is provided #64

Open
zaosoula opened this issue Feb 1, 2024 · 0 comments
Open

No hover state on BaseButton when attr HREF or TO is provided #64

zaosoula opened this issue Feb 1, 2024 · 0 comments

Comments

@zaosoula
Copy link
Contributor

zaosoula commented Feb 1, 2024

When a BaseButton has href or to, it renders as a `` so the :enabled modifier can't apply (links can't be disabled). It's necessary to properly style buttons but should be removed to properly style link

Reproduce

With hover
Without hover
Without hover

Proprosal

//Bg hover
[`@apply hover:enabled:bg-${config.variant.solid.default.background.light.hover} dark:hover:enabled:bg-${config.variant.solid.default.background.dark.hover}`]:
{},

//Bg hover
          [`@apply hover:enabled:bg-${config.variant.solid.default.background.light.hover} dark:hover:enabled:bg-${config.variant.solid.default.background.dark.hover}`]:
            {},
+          [`&a`]:
+            [`@apply hover:bg-${config.variant.solid.default.background.light.hover} dark:hover:bg-${config.variant.solid.default.background.dark.hover}`]:
+              {},
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant