Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Standard modifier order? #42

Closed
swankjesse opened this issue May 24, 2017 · 3 comments
Closed

Standard modifier order? #42

swankjesse opened this issue May 24, 2017 · 3 comments

Comments

@swankjesse
Copy link
Contributor

The official style guides are quiet about whether we should say override public or public override.

Does ktlint wanna enforce one true order?

I made up a standard order for KotlinPoet, but I’m not particular to it.
https://github.com/square/kotlinpoet/blob/master/src/main/java/com/squareup/kotlinpoet/KModifier.kt

@shyiko
Copy link
Collaborator

shyiko commented May 24, 2017

Hi @swankjesse. Absolutely. Kotlin/kotlin-style-guide#3 is still open but I think it's pretty safe to add this rule to the ktlint-ruleset-standard. Thank you for pointing it out.

@shyiko
Copy link
Collaborator

shyiko commented May 28, 2017

Implemented in 0.7.0. Order (same as in Kotlin/kotlin-style-guide#3) is defined here.

I'd appreciate if you could take a vote in #43. Cheers!

@shyiko
Copy link
Collaborator

shyiko commented May 28, 2017

@swankjesse one more thing - https://ktlint.github.io/ :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants