Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

reimplement packet capture in machined #7880

Closed
Tracked by #7532
smira opened this issue Oct 20, 2023 · 0 comments · Fixed by #7931
Closed
Tracked by #7532

reimplement packet capture in machined #7880

smira opened this issue Oct 20, 2023 · 0 comments · Fixed by #7931
Assignees

Comments

@smira
Copy link
Member

smira commented Oct 20, 2023

gopacket library has lots of issues in the way it is implemented, and we don't need full library for packet capture, but rather need it for parsing (in talosctl).

If we rewrite packet capture to use https://github.com/gopacket/gopacket/blob/master/afpacket/afpacket.go, rewrite pcap writer to avoid importing layers, we should get rid of most of gopacket in Talos machined.

Simply dropping PacketCapture from machined API server reduces observed RSS by around 20MiB.

@smira smira self-assigned this Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant