refactor: update packet capture to use 'afpacket' interface #7931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all, this interface is way more performant than `pcap` interface. It is Linux-specific, but we don't care in Talos Linux :) Second, this drop dependency of `machined` on `gopacket/layers` package, which has huge issues with memory allocations and startup time. This cuts around 20MiB of process RSS for all Talos processes. (`talosctl` still requires this `gopacket/layers` library for decoding packets). Fixes siderolabs#7880 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
commented
Nov 7, 2023
| // For those that care, we currently write v2.4 files with nanosecond | ||
| // or microsecond timestamp resolution and little-endian encoding. | ||
| type Writer struct { | ||
| w io.Writer |
There was a problem hiding this comment.
that's stripped down version from gopacket which has no dependency on gopacket/layers
frezbo
approved these changes
Nov 7, 2023
|
/m |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, this interface is way more performant than
pcapinterface. It is Linux-specific, but we don't care in Talos Linux :)Second, this drop dependency of
machinedongopacket/layerspackage, which has huge issues with memory allocations and startup time.This cuts around 20MiB of process RSS for all Talos processes. (
talosctlstill requires thisgopacket/layerslibrary for decoding packets).Fixes #7880