Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

erros with tsc #1792

Closed
guidev opened this issue Jan 16, 2023 · 5 comments
Closed

erros with tsc #1792

guidev opened this issue Jan 16, 2023 · 5 comments

Comments

@guidev
Copy link

guidev commented Jan 16, 2023

after upgrading from 2.3.3 to 3.0.1, if I run tsc I get the following error:

node_modules/mysql2/index.d.ts:86:18 - error TS2320: Interface 'PoolConnection' cannot simultaneously extend types 'PoolConnection' and 'Connection'.
  Named property 'execute' of types 'PoolConnection' and 'Connection' are not identical.

86 export interface PoolConnection extends mysql.PoolConnection, Connection {
                    ~~~~~~~~~~~~~~

node_modules/mysql2/index.d.ts:86:18 - error TS2320: Interface 'PoolConnection' cannot simultaneously extend types 'PoolConnection' and 'Connection'.
  Named property 'unprepare' of types 'PoolConnection' and 'Connection' are not identical.

86 export interface PoolConnection extends mysql.PoolConnection, Connection {
                    ~~~~~~~~~~~~~~


Found 2 errors in the same file, starting at: node_modules/mysql2/index.d.ts:86
@PortalTime
Copy link

PortalTime commented Jan 16, 2023

Hi,

I ran into the same problem and could resolve it by adding in my tsconfig the skipLibCheck:

{ "compilerOptions": { "module": "commonjs", .... "skipLibCheck": true } }

May it will help you as well :)

@sidorares
Copy link
Owner

@guidev @PortalTime if you know the fix properly please submit a PR, I don't maintain typings actively myself

@guidev
Copy link
Author

guidev commented Feb 9, 2023

Hi, just reporting that this is still an issue on 3.1.2

Unfortunately I don't know how to fix it myself

@HofmannZ
Copy link

This is holding us back from upgrading to v3. Is there any LTS on v2?

@sidorares
Copy link
Owner

@HofmannZ currently I don't plan to support multiple major versions at the same time

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants