Multiple clicks on EnterPhoneNumberFragment causes unexpected behavior

[Sagar0-0]

Guidelines

• I have searched searched open and closed issues for duplicates
• I am submitting a bug report for existing functionality that does not work as intended
• This isn't a feature request or a discussion topic

Bug description

Steps to reproduce:

1. Go to the login screen.
2. Enter a valid phone number
3. Click on Continue and Click ok in the Dialog to confirm the Phone number is correct.
4. The loading state of the Continue button will be gone.
5. For some time the user is still on the same screen to Enter Phone number.
6. The user can again press on the Continue button.
7. The application is trying to Navigate to OTP verification screen for the first confirmation, but the user just confirmed again, so the same function Is called again unnecessarily.
8. This can be done multiple down before the app is moved to the OTP screen.
9. This can cause a bad state for the application and unwanted consumption of resources.

The same problem exists with VerificationScreen, which means even after verification is completed, the user will still see the verification screen for some time and can also act on that screen.

Please take a look at the video for better clarity.

Actual behavior:
The user will still see the EnterPhone screen even after a successful Phone confirmation.
Expected behavior:
The user should see the Progress bar until navigated to the next screen.

Possible solutions:
In case of success,
Only set the Progress to false once the user has navigated successfully, this way there is no chance for the user to double click.
This means, when we are navigated to EnterCodeFragment from EnterPhone, or when we have successfully registered after OTP verification.

I have navigated through the entire code causing this issue and made the required changes locally to make this work in the expected behavior. This includes small changes in setting the state of the Progress Bar in the right place.

Please assign this issue to me so that I can raise a PR for the same.

Screenshots

document_6285169237325516997.mp4

Device

Realme GT NEO 3T

Android version

14

Signal version

7.28.4

Link to debug log

No logs as the user was not logged in.