You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched searched open and closed issues for duplicates
I am submitting a bug report for existing functionality that does not work as intended
This isn't a feature request or a discussion topic
Bug description
This issue includes two minor bugs:
In NewCallActivity, the refresh option from Menu doesn't show SwiperRefresh Progress.
Multiple Times clicking on Refresh causes Multiple Refreshes to DB.
Steps to reproduce:
Go to NewCallActivity or Screen in the app.
Use Refresh from OptionMenu
This won't show SwipeRefresh ProgressBar.
If Refresh contacts from OptionsMenu or More is clicked multiple times, then it queues multiple DB calls, while the last one isn't completed. Check logs for confirmation.
Possible Solution:
Simple check if swipeRefresh.isRefreshing then don't trigger onRefresh.
This needs to be implemented at 3 places. NewCallActivity, NewConversationActivity, and ContactSelectionListFragment. I have implemented and tested the solution, and it works perfectly fine. I am ready with a PR.
Screenshots
document_6289627563702621329.mp4
Device
Realme GT NEO 3T
Android version
14
Signal version
7.28.4
Link to debug log
NA
The text was updated successfully, but these errors were encountered:
Guidelines
Bug description
This issue includes two minor bugs:
Steps to reproduce:
Refresh contacts
from OptionsMenu or More is clicked multiple times, then it queues multiple DB calls, while the last one isn't completed. Check logs for confirmation.Possible Solution:
Simple check if swipeRefresh.isRefreshing then don't trigger onRefresh.
This needs to be implemented at 3 places. NewCallActivity, NewConversationActivity, and ContactSelectionListFragment. I have implemented and tested the solution, and it works perfectly fine. I am ready with a PR.
Screenshots
document_6289627563702621329.mp4
Device
Realme GT NEO 3T
Android version
14
Signal version
7.28.4
Link to debug log
NA
The text was updated successfully, but these errors were encountered: