Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refresh Contacts can triggers Multiple DB Calls #13852

Open
3 tasks done
Sagar0-0 opened this issue Dec 23, 2024 · 0 comments
Open
3 tasks done

Refresh Contacts can triggers Multiple DB Calls #13852

Sagar0-0 opened this issue Dec 23, 2024 · 0 comments

Comments

@Sagar0-0
Copy link

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

This issue includes two minor bugs:

  1. In NewCallActivity, the refresh option from Menu doesn't show SwiperRefresh Progress.
  2. Multiple Times clicking on Refresh causes Multiple Refreshes to DB.

Steps to reproduce:

  1. Go to NewCallActivity or Screen in the app.
  2. Use Refresh from OptionMenu
  3. This won't show SwipeRefresh ProgressBar.
  4. If Refresh contacts from OptionsMenu or More is clicked multiple times, then it queues multiple DB calls, while the last one isn't completed. Check logs for confirmation.

Possible Solution:
Simple check if swipeRefresh.isRefreshing then don't trigger onRefresh.

This needs to be implemented at 3 places. NewCallActivity, NewConversationActivity, and ContactSelectionListFragment. I have implemented and tested the solution, and it works perfectly fine. I am ready with a PR.

Screenshots

document_6289627563702621329.mp4

Device

Realme GT NEO 3T

Android version

14

Signal version

7.28.4

Link to debug log

NA

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

1 participant