Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

decoders/sdcard_spi: CMD17/CMD24 bugfix, added support for CMD12,CMD18 #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

decoders/sdcard_spi: CMD17/CMD24 bugfix, added support for CMD12,CMD18 #87

wants to merge 1 commit into from

Conversation

blastsnes
Copy link

  • BUGFIX: CMD17/CMD24 only worked once. Any following CMD17/CMD24 were missed because self.is_cmd17/self.is_cmd24 were not reset after a successful command.
  • TODO implemented: CRC-16 validation in CMD17
  • added support for CMD18 (READ_MULTIPLE_BLOCK)
  • added support for CMD12 (STOP_TRANSMISSION) which CMD18 depends on

decoders/sdcard_spi:
1d43ac9 
- BUGFIX: CMD17/CMD24 only worked once. Any following CMD17/CMD24 were missed because self.is_cmd17/self.is_cmd24 were not reset after a successful command.
- TODO implemented: CRC-16 validation in CMD17
- added support for CMD18 (READ_MULTIPLE_BLOCK)
- added support for CMD12 (STOP_TRANSMISSION) which CMD18 depends on
snmoore added a commit to Inflowmatix/libsigrokdecode that referenced this pull request Nov 11, 2022
@snmoore
Fix CMD17 READ_SINGLE_BLOCK only working once
dcd73ae 
Reset the CMD17 state once the block data has been handled.

Fix by blastsnes, taken from PR sigrokproject#87 from https://github.com/blastsnes/libsigrokdecode_sd_card_spi/tree/sd_card_spi_fix
@dvosully dvosully mentioned this pull request Feb 15, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blastsnes