Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds decoder for SENT (SAE J2716) #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgressmann
Copy link

No description provided.

@fenugrec
Copy link
Contributor

P.S. - would be helfpul to link to the corresponding PRs in Dumps and Tests

@jgressmann
Copy link
Author

dumps: sigrokproject/sigrok-dumps#41
tests: sigrokproject/sigrok-test#20

@Adrian-Stanea
Copy link

Hi, and thanks for this decoder.

I had to add a prefix to the annotation_rows in the current decoder implementation to remove duplicate IDs. This change seems to be required by the newer libsigrokdecode version.

    annotation_rows = (
         ('row_nibbles', 'Nibbles', (2,)),
         ('row_fields', 'Fields', (1, 3, 4, 5, 13)),
         ('row_fast', 'Fast', (11, 12, 14, 15, 23, 24)),
         ('row_slow-bit3', 'Slow (Bit 3)', (6, 16, 17, 20, 16, 18, 18, 22)),
         ('row_slow-bit2', 'Slow (Bit 2)', (7, 8, 9, 10, 17, 21)),
         ('row_error', 'Error', (0,)),
    )

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants