Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix replace with compliant image mediatype #4077

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix replace with compliant image mediatype #4077

wants to merge 1 commit into from

Conversation

stgrace
Copy link

@stgrace stgrace commented Feb 21, 2025

Fixes #4076

Summary

Bug in replacing attestation.

Release Note

NONE

Documentation

No docs

@stgrace stgrace requested a review from a team as a code owner February 21, 2025 15:18
@stgrace stgrace force-pushed the fix-replace branch 2 times, most recently from 1c9671a to 1334aea Compare February 21, 2025 15:23
@stgrace
Fix replace with non compliant image mediatypes
157b203 
Signed-off-by: Stef Graces <stefgraces@hotmail.com>
@stgrace stgrace changed the title Fix replace with non compliant image mediatypes Fix replace with compliant image mediatypes Feb 21, 2025
@stgrace stgrace changed the title Fix replace with compliant image mediatypes Fix replace with compliant image mediatype Feb 21, 2025
@bobcallaway
Copy link
Member

Could you please write a test that ensures we don’t regress this in the future?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong mediatype on attestation replace
2 participants
@stgrace @bobcallaway