Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace silverstripe/react-injector with admin injector #1891

Open
4 tasks
emteknetnz opened this issue Jan 16, 2025 · 0 comments
Open
4 tasks

Replace silverstripe/react-injector with admin injector #1891

emteknetnz opened this issue Jan 16, 2025 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 16, 2025

Follow on from silverstripe/silverstripe-mfa#584 (comment)

https://github.com/silverstripe/react-injector/ is an unmaintained repository that is something of an out of date clone of lib/Injector that is in silverstripe/admin. silverstripe/react-injector is only used by silverstripe/mfa to get the injector functionality without being logged in to admin. It does not appear to be used by silverstripe/silverstripe-login-forms.

Injector should instead be exported as a separate bundle by silverstripe/admin so that it can be consumed both inside and outside of admin.

Acceptance criteria

  • Injector is exported as its own bundle in silverstripe/admin
  • All existing admin functionality that relies on injector continues to work
  • silverstripe/mfa is updated to use the exported bundle rather than silverstripe/react-injector
  • silverstripe/react-injector is archived
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant