Skip to content

Commit 93b74aa

Browse files
KN4CK3Rsilverwind
authored andcommitted
Use information from previous blame parts (go-gitea#28572)
Fixes go-gitea#28545 `git blame` output can contain blocks without commit information if it was outputted before (the `0dafa97ea3f6d9662299579e5be1875cd28baaae 48 26 1` line): ``` fec25436488499df7231f63b857f66457c193d5c 24 25 1 author Bastien Montagne author-mail <bastien@blender.org> author-time 1660731031 author-tz +0200 committer Bastien Montagne committer-mail <bastien@blender.org> committer-time 1660731031 committer-tz +0200 summary LibOverride: Add Make/Reset/Clear entries to IDTemplate contextual menu. previous 839ece6477203382b7a7483062961540180ff1cd source/blender/editors/interface/interface_ops.c filename source/blender/editors/interface/interface_ops.c #include "BLT_translation.h" 0dafa97ea3f6d9662299579e5be1875cd28baaae 48 26 1 3d57bc4397fca53bc9702a27bbf50102827829b0 27 27 1 author Hans Goudey author-mail <hans@blender.org> author-time 1700131315 author-tz +0100 committer Hans Goudey committer-mail <hooglyboogly@noreply.localhost> committer-time 1700131315 committer-tz +0100 summary Cleanup: Move several blenkernel headers to C++ previous 451c054d9b7d3148a646caa5a72fb127a5b5c408 source/blender/editors/interface/interface_ops.cc filename source/blender/editors/interface/interface_ops.cc #include "BKE_context.hh" ``` This PR reuses data from the previous blame part to fill these gaps.
1 parent 63f4ea6 commit 93b74aa

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

routers/web/repo/blame.go

+17-5
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ func RefBlame(ctx *context.Context) {
125125
}
126126

127127
type blameResult struct {
128-
Parts []git.BlamePart
128+
Parts []*git.BlamePart
129129
UsesIgnoreRevs bool
130130
FaultyIgnoreRevsFile bool
131131
}
@@ -175,7 +175,9 @@ func performBlame(ctx *context.Context, repoPath string, commit *git.Commit, fil
175175
func fillBlameResult(br *git.BlameReader, r *blameResult) error {
176176
r.UsesIgnoreRevs = br.UsesIgnoreRevs()
177177

178-
r.Parts = make([]git.BlamePart, 0, 5)
178+
previousHelper := make(map[string]*git.BlamePart)
179+
180+
r.Parts = make([]*git.BlamePart, 0, 5)
179181
for {
180182
blamePart, err := br.NextPart()
181183
if err != nil {
@@ -184,13 +186,23 @@ func fillBlameResult(br *git.BlameReader, r *blameResult) error {
184186
if blamePart == nil {
185187
break
186188
}
187-
r.Parts = append(r.Parts, *blamePart)
189+
190+
if prev, ok := previousHelper[blamePart.Sha]; ok {
191+
if blamePart.PreviousSha == "" {
192+
blamePart.PreviousSha = prev.PreviousSha
193+
blamePart.PreviousPath = prev.PreviousPath
194+
}
195+
} else {
196+
previousHelper[blamePart.Sha] = blamePart
197+
}
198+
199+
r.Parts = append(r.Parts, blamePart)
188200
}
189201

190202
return nil
191203
}
192204

193-
func processBlameParts(ctx *context.Context, blameParts []git.BlamePart) map[string]*user_model.UserCommit {
205+
func processBlameParts(ctx *context.Context, blameParts []*git.BlamePart) map[string]*user_model.UserCommit {
194206
// store commit data by SHA to look up avatar info etc
195207
commitNames := make(map[string]*user_model.UserCommit)
196208
// and as blameParts can reference the same commits multiple
@@ -232,7 +244,7 @@ func processBlameParts(ctx *context.Context, blameParts []git.BlamePart) map[str
232244
return commitNames
233245
}
234246

235-
func renderBlame(ctx *context.Context, blameParts []git.BlamePart, commitNames map[string]*user_model.UserCommit) {
247+
func renderBlame(ctx *context.Context, blameParts []*git.BlamePart, commitNames map[string]*user_model.UserCommit) {
236248
repoLink := ctx.Repo.RepoLink
237249

238250
language := ""

0 commit comments

Comments
 (0)