Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid multiple definition of XXX #1

Closed
qyvlik opened this issue Aug 11, 2017 · 2 comments
Closed

Avoid multiple definition of XXX #1

qyvlik opened this issue Aug 11, 2017 · 2 comments
Labels
bug resolved
Milestone
Version 0.2

Comments

@qyvlik
Copy link

qyvlik commented Aug 11, 2017

Avoid multiple definition of XXX, use static inline may be better.

qpromisehelpers.h#L21

qpromisehelpers.h#L30

qpromisehelpers.h#L30
@simonbrunel simonbrunel added this to the Version 0.2 milestone Aug 11, 2017
@simonbrunel
Copy link
Owner

@qyvlik thanks. inline is missing to avoid the multiple definitions, not sure that static is useful.

@simonbrunel
Copy link
Owner

Fixed in 5d6bcc4

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug resolved
Projects
None yet
Milestone
Version 0.2
Development

No branches or pull requests
2 participants
@simonbrunel @qyvlik