Skip to content

Refresh Token not renewed #50

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
hipslu opened this issue Aug 21, 2022 · 3 comments
Closed

Refresh Token not renewed #50

hipslu opened this issue Aug 21, 2022 · 3 comments

Comments

@hipslu
Copy link

hipslu commented Aug 21, 2022

First of all, thanks for this project!

Currently, the refresh token is used to obtain new access tokens, but the refresh token itself is never updated - which leads to the problem having the initial refresh token not beeing valid anymore, forcing the user to reauthenticate.

so i think simply storing the new refresh token as well when getting the new access token would fix that, so adding the following two lines should do the trick:

refresh_token = response['refresh_token']
config.set(username, 'refresh_token', OAuth2Helper.encrypt(cryptographer, refresh_token))

what do you think?

@D4rki91
Copy link

D4rki91 commented Aug 22, 2022

Hey,

Do you use the Local Server Auth or External Server Auth?

Kind regards

@hipslu
Copy link
Author

hipslu commented Aug 22, 2022

local server auth

@simonrob
Copy link
Owner

Thanks very much for raising this – it is a clear oversight (but unrelated to the authentication mode - it applies in all cases)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants