Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Source flags needs to handle if the planet doesn't cross the scan #1073

Open
msilvafe opened this issue Dec 19, 2024 · 1 comment
Open

Source flags needs to handle if the planet doesn't cross the scan #1073

msilvafe opened this issue Dec 19, 2024 · 1 comment

Comments

@msilvafe
Copy link
Contributor

The preprocess method SourceFlags calls coords.planets.compute_source_flags which currently fails if the planet is not present in the observation. We need to run this source flagging step on all CMB observations because we let the moon and other SSOs (Jupiter, Saturn, Mars, Venus, etc.) cross through our CMB field but we don't want them binned into the maps. However the planets are only present in a few observations. So we either need to call planet.coords.get_scan_q() in SourceFlags to check if the planet is in the observation first before calling compute_source_flags or add the logic into compute_source_flags after the call to get_scan_P.

@msilvafe
Copy link
Contributor Author

@RemingtonGerras pointed out coords.planets.get_nearby_sources perhaps we can use that to do the logic check in SourceFlags

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant