Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use httpx for tests #3

Closed
simonw opened this issue Oct 5, 2019 · 1 comment
Closed

Use httpx for tests #3

simonw opened this issue Oct 5, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Oct 5, 2019 •
edited
Loading

It currently looks like this plugin will result in some changes to Datasette. Once those changes are shipped, I will need to clean up the workarounds from this plugin.

I was going to take advantage of new testing utilities aimed at plugins simonw/datasette#580 - but I no longer see the need for that since httpx is great.
@simonw simonw added the enhancement New feature or request label Oct 5, 2019
@simonw
Copy link
Owner Author

simonw commented Feb 28, 2020

I've started using httpx as a cleaner way of writing tests in other plugins and it works really well. I should use that here. Example: https://github.com/simonw/datasette-mask-columns/blob/f6f08ce21bdfc2731a02c42e1c9e25b4df769292/tests/test_mask_columns.py

@simonw simonw changed the title Clean up hacks after making improvements to Datasette Use httpx for tests Feb 28, 2020
@simonw simonw closed this as completed in 1b4379c Feb 28, 2020
@simonw simonw mentioned this issue Feb 28, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw