Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Type errors in request-compose and grant 5.4.11 #235

Closed
daffl opened this issue Mar 20, 2021 · 3 comments
Closed

Type errors in request-compose and grant 5.4.11 #235

daffl opened this issue Mar 20, 2021 · 3 comments

Comments

@daffl
Copy link

daffl commented Mar 20, 2021

I am getting TypeScript compilation errors with the recently released version 5.4.11 from request-compose:

Screen Shot 2021-03-20 at 12 57 45 PM
@simov
Copy link
Owner

simov commented Mar 20, 2021

I was about to fix that, not sure how I missed it.

@simov
Copy link
Owner

simov commented Mar 20, 2021 •
edited
Loading

Published the fix with v5.4.12

I have set that type to any until I figure out a better way to do it. It's an edge case anyway. Also for some reason my test tsconfig was not catching this error, so I cleaned it up and I was able to reproduce it.

Let me know if you find anything else.

@simov simov closed this as completed Mar 21, 2021
@daffl daffl mentioned this issue Mar 22, 2021
Merged
@daffl
Copy link
Author

daffl commented Mar 22, 2021

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daffl @simov