-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Green line artifact on right side of gif #64
Comments
Could you share the original recording? (Just ZIP it and attach it here) So I can reproduce it locally. |
Sure thing! |
I think it's because the dimensions of the video is 384x529, which is a problem, as both sides have to be divisible by 4. @kornelski Any thoughts what we could do about this? |
If AVFoundation and ffmpeg both agree that there's a green line there, there's a green line there. It might be caused by Mojave encoding the video incorrectly, so I'd report that to Apple as a bug in the screen recording tool. But I think odd sizes of videos are "legal" in general. Internally they may need to be padded, which is a pain to deal with, but should be supported (e.g. JPEG only supports multiplies of 8 or even 16, but you can have any size after conversion). The cause of this is probably an off-by-one error in computation of the size of the chroma channel. If you really wanted a workaround for this, you could try decoding the video into planar YUV format. Assuming you'd get YUV bitplanes in the right sizes (without that garbage line), you could then resize chroma with appropriate padding to match luma's size. |
@IssueHunt has funded $60.00 to this issue.
|
Closing as I agree this is not something we should fix. The bounty now applies to #183 instead. |
The bounty for this issue now applies to #183 instead.
Hey,
I'm seeing green artifacts on the right side of the resulting gif. The input video file is taken straight from the Mojave screen recording tool.
Here's a sample:
Note: This is not an easy issue and requires good Swift and macOS/iOS experience.
The text was updated successfully, but these errors were encountered: