Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

npm audit security vulnerability in semver <= 7.5.2 #2163

Open
josundt opened this issue Jul 3, 2023 · 6 comments
Open

npm audit security vulnerability in semver <= 7.5.2 #2163

josundt opened this issue Jul 3, 2023 · 6 comments

Comments

@josundt
Copy link

josundt commented Jul 3, 2023

npm audit gives warning about the indirect semver dependency:

semver <-- normalize-package-data <-- read-pkg <-- read-pkg-up

Updating to latest version of read-pkg-up should mitigate this.

@Eejit43
Copy link

Eejit43 commented Aug 15, 2023

Is there any reason that can't be bumped? If not that would definitely be great to do.

@pcorpet
Copy link

pcorpet commented Aug 21, 2023

It would require to switch eslint-plugin-unicorn to ESM. I'm not sure if this is something that the maintainer wants. @sindresorhus would you consider moving to ESM, can I help?

@sindresorhus
Copy link
Owner

We cannot use ESM here until we only support the new ESLint flat config.

@sindresorhus
Copy link
Owner

As with 99% of all audit warnings, this one too does not apply to most projects, including this one: https://overreacted.io/npm-audit-broken-by-design/

There are ways to ignore audit warnings: https://stackoverflow.com/questions/72713764/how-to-ignore-a-package-during-npm-audit

And hopefully even better ways in the future: npm/rfcs#18

@ehoogeveen-medweb
Copy link

I believe this specific issue no longer applies, as semver v5.7.2 was released with a backport of the fix for the security vulnerability (changelog, pull request). As a result, npm audit no longer warns.

@samualtnorman
Copy link

samualtnorman commented Apr 16, 2024

read-pkg-up is deprecated, maybe this issue should be renamed to be about moving to read-package-up

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants