Possible portNumbers argument validation bug?

[jonahsnider]

get-port/index.js

Lines 163 to 165 in 50e24f6

	if (to < minPort || to > maxPort + 1) {
	throw new RangeError(`'to' must be between ${minPort} and ${maxPort + 1}`);
	}

Is this + 1 logic correct?

If you run this snippet:

import { portNumbers } from 'get-port';

console.log([...portNumbers(65535, 65536)]);

You get the output

[ 65535, 65536 ]

The maximum port number should be 65,535 but the argument validation seems to allow the value 65536 to be returned.

If this is a bug I'd be happy to PR it.

[sindresorhus]

@mastrzyz

[mastrzyz]

Interesting, this does look like a bug but , I'd like some more context @sindresorhus , previously the code was :

	if (to < 1024 || to > 65_536) {
		throw new RangeError('`to` must be between 1024 and 65536');
	}

My change d03c07b , changed it to :

       const maxPort = 65_535;
	if (to < minPort || to > maxPort + 1) {
		throw new RangeError(`'to' must be between ${minPort} and ${maxPort + 1}`);
	}

So its effectively the same code as before, was it always a bug here?

[sindresorhus]

was it always a bug here?

Seems so.