Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove import {URL} from 'url'; when TypeScript gets fixed #989

Closed
Tracked by #2075
szmarczak opened this issue Dec 12, 2019 · 4 comments
Closed
Tracked by #2075

Remove import {URL} from 'url'; when TypeScript gets fixed #989

szmarczak opened this issue Dec 12, 2019 · 4 comments
Labels
enhancement This change will extend Got features external The issue related to an external project
Milestone

Comments

@szmarczak
Copy link
Collaborator

szmarczak commented Dec 12, 2019

#983 (comment)
DefinitelyTyped/DefinitelyTyped#34960

@szmarczak szmarczak added enhancement This change will extend Got features external The issue related to an external project labels Dec 12, 2019
@xamgore
Copy link
Contributor

xamgore commented Aug 23, 2020

Should warn that jest replaces the global URL with its own implementation, so maybe it's a good idea to leave it as is. Related issue: #1414 (comment)

@sindresorhus
Copy link
Owner

@xamgore That's a problem for Jest to deal with. Got targets Node.js, not a weird Jest environment. You should open an issue on Jest if there are problems.

@SimenB
Copy link

SimenB commented Aug 23, 2020

The issue to track in Jest is jestjs/jest#2549, but for an actual solution to the issue with URL you need to track is nodejs/node#28823

@sindresorhus sindresorhus mentioned this issue Jul 5, 2022
4 tasks
@szmarczak
Copy link
Collaborator Author

FYI Jest apparently fixed this in jestjs/jest@78d4088 which is live since 2022.04.25.

@szmarczak szmarczak added this to the Got v13 milestone Jul 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement This change will extend Got features external The issue related to an external project
Projects
None yet
Development

No branches or pull requests

4 participants