Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nested parcels gets unmounted multiple times and throws #164

Open
tretne opened this issue Feb 3, 2023 · 3 comments
Open

Nested parcels gets unmounted multiple times and throws #164

tretne opened this issue Feb 3, 2023 · 3 comments
Labels

Comments

@tretne
Copy link

tretne commented Feb 3, 2023

Hi!

I'm having a scenario where parcel A is mounted as <Parcel config={() => System.import('@parcelA')} /> in the main app and that parcel in turn mounts parcel B as <Parcel config={() => System.import('@parcelB')} />.

When parcel A then gets unmounted, parcel B will be unmounted twice. Once by componentWillUnmount in the Parcel component of parcel A here and once as the child of parcel A here.

One of these times parcel B already has the status "UNMOUNTING" here and will cause the error https://single-spa.js.org/error/?code=6&arg=&arg=UNMOUNTING to be thrown. Parcel A also will end up with status "SKIP_BECAUSE_BROKEN" and still be kept as a child parcel by the main app.

Using:

  • single-spa v5.9.4
  • single-spa-react v5.0.0
@boringContributor
Copy link

How do you use the Parcel component in react v5 ? This seems not even to work anymore

@MilanKovacic
Copy link
Contributor

How do you use the Parcel component in react v5 ? This seems not even to work anymore

There was an error in one of the published versions. It should be fixed now.

@sandeeppatel344
Copy link

Hi!

I'm having a scenario where parcel A is mounted as <Parcel config={() => System.import('@parcelA')} /> in the main app and that parcel in turn mounts parcel B as <Parcel config={() => System.import('@parcelB')} />.

When parcel A then gets unmounted, parcel B will be unmounted twice. Once by componentWillUnmount in the Parcel component of parcel A here and once as the child of parcel A here.

One of these times parcel B already has the status "UNMOUNTING" here and will cause the error https://single-spa.js.org/error/?code=6&arg=&arg=UNMOUNTING to be thrown. Parcel A also will end up with status "SKIP_BECAUSE_BROKEN" and still be kept as a child parcel by the main app.

Using:

  • single-spa v5.9.4
  • single-spa-react v5.0.0

I am also facing same issue.
How we can solve?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants