From d1225cd02a8e2044c656c4d1b9dfa43bb5dda65f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=86=B7=E9=85=94=E9=96=91=E5=90=9F?= <50296129+Jint-lzxy@users.noreply.github.com> Date: Mon, 25 Dec 2023 22:40:43 +0800 Subject: [PATCH] feat(script): skip dependency installation by default (#1114) IMO the default choice for dependency installation in `install.ps1` is a bit misleading (see Discussion #1106). afaik most users won't even "visit" the dynamic provider feature of Neovim, and those who know what they're doing can still continue with the dependency installation by typing `Y/y`. So I think a more reasonable default should be `N` (i.e. skipping provider installation altogether.) --- scripts/install.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/install.ps1 b/scripts/install.ps1 index 0203ca183..5144ff9b1 100644 --- a/scripts/install.ps1 +++ b/scripts/install.ps1 @@ -242,7 +242,7 @@ function confirm_dep_inst ([Parameter(Mandatory = $True)][ValidateNotNullOrEmpty $_opt_yes = New-Object System.Management.Automation.Host.ChoiceDescription "&Yes","Will install $PkgName dependencies" $_opt_no = New-Object System.Management.Automation.Host.ChoiceDescription "&No","Will SKIP installing $PkgName dependencies" - $USR_CHOICE = $Host.ui.PromptForChoice($_title,$_message,[System.Management.Automation.Host.ChoiceDescription[]]($_opt_yes,$_opt_no),0) + $USR_CHOICE = $Host.ui.PromptForChoice($_title,$_message,[System.Management.Automation.Host.ChoiceDescription[]]($_opt_yes,$_opt_no),1) if ($USR_CHOICE -eq 0) { return $True } else {