-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ruamel.yaml 0.17.32 version buggy for 0.1.22 singularity-hpc release #655
Comments
I don't think so, and I think for the time being we should pin this version in the shpc/version.py. Would you like to submit a PR for that? |
Sure I can do that. ruamel.yaml==0.17.21 for shpc v0.1.22? |
Yep let’s do that for now - thank you! 🙏 |
Can you open a new branch for me to do a PR to? I can't do a PR to the 0.1.22 tag. |
the tags are releases, so you wouldn’t do a PR against a release, but rather the current main branch. To do that you can fork the repository, clone your fork, checkout a branch, do the changes, commit and push, and then open the PR from your fork against main. It’s not typical to allow write access when contributing to a repository. Let me know if you have any questions along the way - happy to help! |
Ok PR created - #657 |
This version will need to be updated (and the bug fixed) as we are broken in conda: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=783260&view=logs&jobId=656edd35-690f-5c53-9ba3-09c10d0bea97&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3 |
@audreystott is this something you might be able to work on? Note that we would want to import ruamel.yaml, and there are examples here: https://yaml.readthedocs.io/en/latest/example.html |
When installing -b 0.1.22 on Ubuntu 22.04, shpc appears to install successfully (lines have been omitted):
However, it seems the new ruamel version (0.17.32) causes an error when running the
shpc config edit
command (shpc --help
is fine):After installing ruamel.yaml 0.17.21 as follows, I can successfully run the
shpc config edit
command and also othershpc
commands:Am I doing something wrong with my initial install commands?
The text was updated successfully, but these errors were encountered: