Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Constants::getPassByReferenceFunctions(): contains methods #156

Open
jrfnl opened this issue Feb 18, 2020 · 0 comments
Open

Constants::getPassByReferenceFunctions(): contains methods #156

jrfnl opened this issue Feb 18, 2020 · 0 comments
Labels

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Feb 18, 2020

The array in Constants::getPassByReferenceFunctions() includes a number of methods, but no indication that:

  1. These are methods and should only be recognized as the function when called as a method.
  2. What class these methods come from.

This means that, for example, if someone would currently define a global function addTask() which doesn't use pass by reference, the sniff may have a false negative as parameter 3 would not be checked.

The same goes, of course, for userland classes defining a function of the same name as one of these, as well as namespaced functions.

@sirbrillig sirbrillig added the bug label Feb 18, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants