Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Gfranxman/313 prefer dotlocalbin as install location #342

Merged

Conversation

gfranxman
Copy link
Member

No description provided.

@gfranxman gfranxman requested a review from calvinhp August 14, 2024 22:28
@gfranxman gfranxman changed the title Gfranxman/313 prefer dotlocalbin as install location feat: Gfranxman/313 prefer dotlocalbin as install location Aug 14, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
feat: add function to move files to bin folder

I've added the move_to_bin_folder function in install.sh.
This function moves a file to the specified destination.
If the destination is not writable, it uses sudo to move the file.
I updated the install_kubectl, install_kind, and install_scaf functions to use the new function.
- Previously, the script attempted to move a temporary downloaded file into `$DESTINATION`.
- The new version of the script moves the file into the directory given by `dirname $DESTINATION`.
Copy link
Contributor

@rochecompaan rochecompaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@daveoconnor daveoconnor merged commit dbb3556 into main Sep 4, 2024
4 checks passed
@daveoconnor daveoconnor deleted the gfranxman/313-prefer-dotlocalbin-as-install-location branch September 4, 2024 04:00
github-actions bot pushed a commit that referenced this pull request Sep 21, 2024
## [1.15.0](v1.14.0...v1.15.0) (2024-09-21)

### Features

* added local registry support and improved setup (close [#353](#353)) ([32de8c7](32de8c7))
* Gfranxman/313 prefer dotlocalbin as install location ([#342](#342)) ([dbb3556](dbb3556))
* implement s3 storage for static and media files on production ([#339](#339)) ([76afd23](76afd23))
* implement scaf challenge for session recording ([#379](#379)) ([0c091af](0c091af))
* **install.sh:** force re-download of Scaf on each install ([#338](#338)) ([f7ef3e3](f7ef3e3))
* op inject secrets (close [#368](#368)) ([58090b5](58090b5))
* reorder environment variables in k8s django config ([#350](#350)) ([f2cb234](f2cb234))
* script to test cookiecutter part of Scaf ([952e276](952e276))

### Bug Fixes

* Fixes frontend tests ([#363](#363)) ([4a2a5b2](4a2a5b2))
* mailhog port config (closes [#249](#249)) ([cea1602](cea1602))
* Specify the full container path, including the host. ([#309](#309)) ([2fa7276](2fa7276)), closes [#308](#308)
* Update logo ([#373](#373)) ([afe2d84](afe2d84))
* use GitHub token for semantic release workflow ([b5eef60](b5eef60))

### Documentation

* add disk space warning to README ([#385](#385)) ([4262b2d](4262b2d))
* update related to optional GraphQL ([#366](#366)) ([92bfc8d](92bfc8d)), closes [#290](#290)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants