Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Zag 1.0 Support #3258

Closed
Hugos68 opened this issue Feb 25, 2025 · 2 comments · Fixed by #3257
Closed

Zag 1.0 Support #3258

Hugos68 opened this issue Feb 25, 2025 · 2 comments · Fixed by #3257
Labels
feature request Request a feature or introduce and update to the project.
Milestone

Comments

@Hugos68
Copy link
Contributor

Hugos68 commented Feb 25, 2025

Describe the feature in detail (code, mocks, or screenshots encouraged)

Zag released 1.0, Skeleton should update it's dependencies.

What type of pull request would this be?

Enhancement

Provide relevant links or additional information.

No response

@Hugos68 Hugos68 added the feature request Request a feature or introduce and update to the project. label Feb 25, 2025
@Hugos68 Hugos68 mentioned this issue Feb 25, 2025
12 tasks
@Hugos68 Hugos68 linked a pull request Feb 26, 2025 that will close this issue
12 tasks
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Feb 26, 2025
@stalkerg
Copy link

Hello,

Sorry, but I think replace $bindable by onValueChange={(e) => (valueCollapsible = e.value)} it's a big change! From my Svelte point of view, it's a significant degradation. I don't think it's a good idea to do it without discussion inside the community.
I didn't find any specific ticket about it, but you already have this in the new PR.

@endigo9740
Copy link
Contributor

endigo9740 commented Feb 27, 2025

@stalkerg we were already planning to create a post and share more info on this Svelte change. Since you suggested this, and especially since you've shared your thoughts in a couple other places, I'd appreciate if you would read this and come at it with an open mind.

Our aim is to help move Skeleton forward, and the challenges imposed by using two-way binding are not trivial. But again, the post above shares a lot more specifics and details.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature request Request a feature or introduce and update to the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants