i18n - remove hardcoded text within components

[endigo9740]

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!

Let's audit and review what components have fixed text within them. Off the top of my head this includes, but is not limited to:

• dialogs
• toasts (dismiss button)
• stepper (next/complete buttons)

This will allow support for non-English languages.

What type of pull request would this be?

Enhancement

Any links to similar examples or other references we should review?

No response

[moshe5745]

There is hardcoded text in FileDropZone, Paginator too.

I can try to PR this.
But I need to understand where the text will come from.

[endigo9740]

@moshe5745 Hey, yeah the default value is in English, but the entire message area contents are replaceable. So it's kind of yes and no on this one. Technically this is already possible to replace.

[moshe5745]

What about the Paginator? (I updated the original comment)

[endigo9740]

Funny enough @ryceg and I were just talking about that. See our conversation in his first response here:
#520

This is a likely candidate for change. The Paginator itself needs a bit of a de#date, so I might knock this out along side that.

[moshe5745]

Ok, but how would you prefer the text "injection"? Props or slots?

[moshe5745]

This is the only hard-coded text I found in the dialog:

Interesting what is the best practice for this?

Because it seems a little funny for the developer to enter "Dialog" in the local language.

[endigo9740]

@moshe5745 Honestly Mosh this ticket might best left to me. That or at least just give me an opportunity to do a proper audit through each and all features in Skeleton to identify what needs to be changed. That probably won't make it into this release as I'm actively working to complete updates to the dialog/toast/table refactors. But may be something I can get to soon.

Currently I just don't know what I don't know as far as what needs to be changed and how we want to handle it. But I'll ping you on here when I get a chance to revisit this ticket.

I'd recommend reaching out on Discord in the #contributors channel if you want to discuss items where we could use contributions right now. That don't require so much prep work!

[endigo9740]

I've completed a final audit of our library, looking for additional instances that might need to be changed. I think with the recent update to Toasts/Drawers we're now good. We'll keep this approach in mind for future components, but I think for now we're good here. Still LOTS to do on the i18n front, but this is a good first step.